linux-kernel - Re: [PATCH] [Trivial] staging: go7007: Framesizes features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120421134938.GT6498@mwanda>
Date:	Sat, 21 Apr 2012 16:49:38 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	my84@...ru
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, mchehab@...radead.org,
	dhowells@...hat.com, justinmattock@...il.com,
	linux-media@...r.kernel.org
Subject: Re: [PATCH] [Trivial] staging: go7007: Framesizes features

On Sat, Apr 21, 2012 at 05:04:03PM +0400, my84@...ru wrote:
> 
> Correct framesizes
> 
> Signed-off-by Volokh Konstantin <my84@...ru>
>

Looks good.  But could you write a proper changelog?  What is the
effect for the user?  How did you find these numbers?  Have you
tested the changes?  It should mention something about that this
affects boards with GO7007_SENSOR_TV.

Btw, how many boards are their that have a GO7007_SENSOR_TV but
don't have a GO7007_BOARD_HAS_TUNER?  Should the comment be updated?

The changelog says it "Correct framesizes" but it doesn't actually
correct anything, it just adds new features that weren't supported
before.

Don't put [Trivial] in the subject line.  Trivial patches are things
like spelling mistakes in comments.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/