linux-kernel - Re: [PATCH] kernel: sys.c: Fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F93364E.2010805@xenotime.net>
Date:	Sat, 21 Apr 2012 15:35:58 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Valentin Ilie <valentin.ilie@...il.com>
CC:	richard -rw- weinberger <richard.weinberger@...il.com>,
	akpm@...ux-foundation.org, paul.gortmaker@...driver.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: sys.c: Fixed coding style issues

On 04/21/2012 08:27 AM, Valentin Ilie wrote:

>> This kind of patch is not easy to review.
>> Can you please prove that no logic has changed?
>> E.g. By comparing the object file before and after your patch...
> 
> Everything seems to be OK.
> 
> The diff is because the old version had an unnecessary \n in two places.

But Richard asked you to compare the object files (binary files,
kernel/sys.o) to make sure that they are the same.


> $ checkpatch.pl -q --file --terse /tmp/test/sys.c | grep total
> total: 33 errors, 18 warnings, 2057 lines checked
> $ checkpatch.pl -q --file --terse /tmp/test/sys_patched.c | grep total
> total: 4 errors, 14 warnings, 2055 lines checked
> 
> $ diff -iEbwB sys.c sys_patched.c
> 215,216c215
> < 			else if ((who != cred->uid) &&
> < 				 !(user = find_user(who)))
> ---
>> 		else if ((who != cred->uid) && !(user = find_user(who)))
> 280,281c279
> < 			else if ((who != cred->uid) &&
> < 				 !(user = find_user(who)))
> ---
>> 		else if ((who != cred->uid) && !(user = find_user(who)))
> 
> 



-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/