linux-kernel - Re: [Patch] Touch: DA9052/53 touch screen driver v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120421063855.GA2360@core.coreip.homeip.net>
Date:	Fri, 20 Apr 2012 23:38:55 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Ashish Jangam <ashish.jangam@...tcummins.com>
Cc:	sameo@...ux.intel.com, m.grzeschik@...gutronix.de,
	randy.dunlap@...cle.com, linux-kernel@...r.kernel.org
Subject: Re: [Patch] Touch: DA9052/53 touch screen driver v2

Hi Ashish,

On Fri, Apr 20, 2012 at 05:58:45PM +0530, Ashish Jangam wrote:
> +static irqreturn_t da9052_ts_pendwn_irq(int irq, void *data)
> +{
> +	struct da9052_tsi *tsi = data;
> +
> +	if (!tsi->stopped) {
> +		/* Mask PEN_DOWN event and unmask TSI_READY event */
> +		disable_irq_nosync(tsi->da9052->irq_base + tsi->irq_pendwn);
> +		enable_irq(tsi->da9052->irq_base + tsi->irq_datardy);

Why did you switch to using irq_base here? da9052_onkey driver does not
do that, should it?

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/