linux-kernel - RE: [Patch] Touch: DA9052/53 touch screen driver v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C3AE124F08223B42BC95AEB82F0F6CED2D5624CA@KCHJEXMB02.kpit.com>
Date:	Tue, 24 Apr 2012 13:48:43 +0000
From:	Ashish Jangam <Ashish.Jangam@...tcummins.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"m.grzeschik@...gutronix.de" <m.grzeschik@...gutronix.de>,
	"randy.dunlap@...cle.com" <randy.dunlap@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Anthony Olech <Anthony.Olech@...semi.com>
Subject: RE: [Patch] Touch: DA9052/53 touch screen driver v2

> On Fri, Apr 20, 2012 at 05:58:45PM +0530, Ashish Jangam wrote:
> > +static irqreturn_t da9052_ts_pendwn_irq(int irq, void *data)
> > +{
> > +	struct da9052_tsi *tsi = data;
> > +
> > +	if (!tsi->stopped) {
> > +		/* Mask PEN_DOWN event and unmask TSI_READY event */
> > +		disable_irq_nosync(tsi->da9052->irq_base + tsi->irq_pendwn);
> > +		enable_irq(tsi->da9052->irq_base + tsi->irq_datardy);
> 
> Why did you switch to using irq_base here? da9052_onkey driver does not
> do that, should it?
On i.mx53 loco board irq_base was required so to keep driver working across
boards this was introduced. Need to fix this in onkey driver. 
> 
> Thanks.
> 
> --
> Dmitry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/