linux-kernel - [PATCH resend v3] x86: memtest: WARN if bad RAM found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120423182630.GA13067@burratino>
Date:	Mon, 23 Apr 2012 13:26:30 -0500
From:	Jonathan Nieder <jrnieder@...il.com>
To:	x86@...nel.org
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Ben Hutchings <ben@...adent.org.uk>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Dave Jones <davej@...hat.com>
Subject: [PATCH resend v3] x86: memtest: WARN if bad RAM found

From: Ben Hutchings <ben@...adent.org.uk>
Date: Mon, 5 Dec 2011 04:00:58 +0000

The novice who enables CONFIG_MEMTEST may not realize that it is not a
particularly thorough test.  If we find any bad bits of RAM then there
is a fair chance that there are other bad bits we fail to detect; add
a WARNING for this situation so people helping debug ensuing problems
can understand what happened.

The warning text gives advice to allow the sysadmin to run a more
thorough test and suppress the warning.

	Bad RAM detected. Use memtest86+ to perform a thorough test
	and the memmap= parameter to reserve the bad areas.

Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
Signed-off-by: Jonathan Nieder <jrnieder@...il.com>
---
Jonathan Nieder wrote:

> The patch below last visited this list on 2 April, about a week and a
> half ago.  No reply.

Are Ben and I the only ones who care either way about this change?

 arch/x86/mm/memtest.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/mm/memtest.c b/arch/x86/mm/memtest.c
index c80b9fb95734..38caeb44a218 100644
--- a/arch/x86/mm/memtest.c
+++ b/arch/x86/mm/memtest.c
@@ -30,6 +30,8 @@ static u64 patterns[] __initdata = {
 
 static void __init reserve_bad_mem(u64 pattern, u64 start_bad, u64 end_bad)
 {
+	WARN_ONCE(1, "Bad RAM detected. Use memtest86+ to perform a thorough test\n"
+		  "and the memmap= parameter to reserve the bad areas.");
 	printk(KERN_INFO "  %016llx bad mem addr %010llx - %010llx reserved\n",
 	       (unsigned long long) pattern,
 	       (unsigned long long) start_bad,
-- 
1.7.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/