linux-kernel - Re: [PATCH 2/6] hid: Scan the device for group info before adding it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Apr 2012 14:41:13 +0200
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] hid: Scan the device for group info before adding it

> > +static int hid_scan_report(struct hid_device *hid)
> > +{
> > +	unsigned int page = 0, delim = 0;
> > +	__u8 *start = hid->dev_rdesc;
> > +	__u8 *end = start + hid->dev_rsize;
> 
> Where do these dev_rdesc and dev_rsize come from? Your patchset doesn't 
> seem to be changing the corresponding struct device members (which are 
> rdesc and rsize currently), right?

Those members are added in the enable-report-fixup-on-rebind patchset,
which this patchset builds on. I only sent that patchset once, to
avoid confusion. Maybe I created some instead. :-)

And yes, the scanning algorithms do not touch the rdesc/rsize
variables, nor the collection state. Those are handled upon attachment
of the driver.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/