linux-kernel - Re: [PATCH v2 2/3] ARM: tegra: Add SMMU enabler in AHB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120424132536.GO8444@arwen.pp.htv.fi>
Date:	Tue, 24 Apr 2012 16:25:37 +0300
From:	Felipe Balbi <balbi@...com>
To:	Hiroshi Doyu <hdoyu@...dia.com>
Cc:	"balbi@...com" <balbi@...com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"ccross@...roid.com" <ccross@...roid.com>,
	"olof@...om.net" <olof@...om.net>,
	"swarren@...dotorg.org" <swarren@...dotorg.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"tony@...mide.com" <tony@...mide.com>,
	"hsweeten@...ionengravers.com" <hsweeten@...ionengravers.com>,
	"jamie@...ieiles.com" <jamie@...ieiles.com>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] ARM: tegra: Add SMMU enabler in AHB

On Tue, Apr 24, 2012 at 03:03:19PM +0200, Hiroshi Doyu wrote:
> > > Only Tegra3 has SMMU.
> > 
> > but all of them ? In that case, you could call this from probe itself,
> > right ? But an ifdef won't work in all cases, so you need to do runtime
> > detection based on some revision register or cpu detection...
> 
> So far we don't have so many variants, and presently TEGRA_3x_SOC
> always has a SMMU. If there were some variants of TEGRA_3x_SOC, where
> some might not have SMMU, then runtime detection would make sense
> there. Now it's something like TEGRA_3x_SOC == SMMU.

the problem is when you have single kernel for TEGRA 2 and TEGRA 3. If
you rely on ifdef, one of them won't work properly, right ? ;-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)