linux-kernel - Re: [PATCH] NFSv4: Add modalias for "nfs4"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120427093047.121bd01b@corrin.poochiereds.net>
Date:	Fri, 27 Apr 2012 09:30:47 -0400
From:	Jeff Layton <jlayton@...hat.com>
To:	Josh Boyer <jwboyer@...hat.com>
Cc:	Trond Myklebust <Trond.Myklebust@...app.com>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NFSv4: Add modalias for "nfs4"

On Fri, 27 Apr 2012 09:10:33 -0400
Josh Boyer <jwboyer@...hat.com> wrote:

> When NFSv4 is configured, the support goes into the nfs.ko module.
> However, nfs-utils seems to pass "nfs4" as the fileststem type for
> NFSv4 mounts.  If the nfs module is not already loaded, the kernel
> will eventually do a module request for "nfs4".  Apparently, this
> has worked until now as the distributions ship a module config file
> that manually aliases "nfs4" to "nfs".
> 
> There is really no need to do this, as the kernel can provide a
> module alias internally for nfs4.  This adds that.
> 
> Signed-off-by: Josh Boyer <jwboyer@...hat.com>
> ---
>  fs/nfs/nfs4proc.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 60d5f4c..d6929c3 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -6550,6 +6550,7 @@ const struct xattr_handler *nfs4_xattr_handlers[] = {
>  module_param(max_session_slots, ushort, 0644);
>  MODULE_PARM_DESC(max_session_slots, "Maximum number of outstanding NFSv4.1 "
>  		"requests the client will negotiate");
> +MODULE_ALIAS("nfs4");
>  
>  /*
>   * Local variables:

Looks reasonable to me.

Reviewed-by: Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/