linux-kernel - Re: [PATCH 1/2] asm-generic: io: remove {read,write} string functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F9B01A9.3000007@zytor.com>
Date:	Fri, 27 Apr 2012 13:29:29 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Mike Frysinger <vapier@...too.org>
CC:	Will Deacon <will.deacon@....com>, linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/2] asm-generic: io: remove {read,write} string functions

On 04/27/2012 09:17 AM, Mike Frysinger wrote:
> On Friday 27 April 2012 06:42:55 Will Deacon wrote:
>> The {read,write}s{b,w,l} functions are not defined across all 
>> architectures and therefore shouldn't be used by portable
>> drivers. We should encourage driver writers to use the
>> io{read,write}{8,16,32}_rep functions instead.
> 
> well, that isn't true today as a grep of the drivers/ tree shows.
> perhaps we should fix that first ?  quite a number of architectures
> do implement these.
> 
>> This patch removes the {read,write} string functions for the
>> generic IO header as they have no place in a new architecture
>> port.
> 
> i don't see any file anywhere that describes what the baseline API
> is supposed to be, and what each set of funcs are for.  there is
> just the random ugliness in each arch's asm/io.h cobbled together
> until things work.  i think that also needs to be addressed before
> we go extending/contracting the API provides by asm-generic/io.h.

And it's is much bigger than asm-generic/io.h, as evidenced by some
other recent events.

For example, we need streaming I/O (memory and I/O) with specific
access sizes, for example.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/