linux-kernel - Re: omap-usb-host.c compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 May 2012 01:29:36 +0200
From:	Nicolas Dechesne <ndec13@...il.com>
To:	John Stultz <johnstul@...ibm.com>
Cc:	Keshava Munegowda <keshava_mgowda@...com>,
	Felipe Balbi <balbi@...com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	lkml <linux-kernel@...r.kernel.org>,
	"Bergmann, Arnd" <arnd@...db.de>
Subject: Re: omap-usb-host.c compile error

On Tue, May 1, 2012 at 11:33 PM, John Stultz <johnstul@...ibm.com> wrote:
> I've been seeing the following compile issue for a few -rcs now:
> drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function
> 'cpu_is_omap3430'
> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function
> 'omap_rev'
> drivers/mfd/omap-usb-host.c:524: error: 'OMAP3430_REV_ES2_1' undeclared
> (first use in this function)
> drivers/mfd/omap-usb-host.c:524: error: (Each undeclared identifier is
> reported only once
> drivers/mfd/omap-usb-host.c:524: error: for each function it appears in.)
>
> Reverting 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 seems to resolve it.
>
> This still isn't fixed in Linus' HEAD. Any plans here?

in fact the problem is related to this part of 1fcb57d0f6

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 95a2e54..c8aae66 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -25,7 +25,6 @@
 #include <linux/clk.h>
 #include <linux/dma-mapping.h>
 #include <linux/spinlock.h>
-#include <linux/gpio.h>
 #include <plat/usb.h>
 #include <linux/pm_runtime.h>

by removing linux/gpio.h, we remove the inclusion of plat/cpu.h which
has the definition of cpu_is_omap3430()
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/