linux-kernel - Re: omap-usb-host.c compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120502092956.3277750a@notabene.brown>
Date:	Wed, 2 May 2012 09:29:56 +1000
From:	NeilBrown <neilb@...e.de>
To:	John Stultz <johnstul@...ibm.com>
Cc:	Keshava Munegowda <keshava_mgowda@...com>,
	Felipe Balbi <balbi@...com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	lkml <linux-kernel@...r.kernel.org>,
	"Bergmann, Arnd" <arnd@...db.de>
Subject: Re: omap-usb-host.c compile error

On Tue, 01 May 2012 14:33:21 -0700 John Stultz <johnstul@...ibm.com> wrote:

> 
> I've been seeing the following compile issue for a few -rcs now:
> drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function 
> 'cpu_is_omap3430'
> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function 
> 'omap_rev'
> drivers/mfd/omap-usb-host.c:524: error: 'OMAP3430_REV_ES2_1' undeclared 
> (first use in this function)
> drivers/mfd/omap-usb-host.c:524: error: (Each undeclared identifier is 
> reported only once
> drivers/mfd/omap-usb-host.c:524: error: for each function it appears in.)
> 
> Reverting 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 seems to resolve it.
> 
> This still isn't fixed in Linus' HEAD. Any plans here?
> 
> thanks
> -john

Following fixes it for me.

NeilBrown

Author: NeilBrown <neilb@...e.de>
Date:   Wed Apr 25 10:52:05 2012 +1000

    omap-usb-host: add include plat/cpu.h
    
    Need this for a version comparison.
    
    Signed-off-by: NeilBrown <neilb@...e.de>

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index c8aae66..7da9496 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -26,6 +26,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/spinlock.h>
 #include <plat/usb.h>
+#include <plat/cpu.h>
 #include <linux/pm_runtime.h>
 
 #define USBHS_DRIVER_NAME      "usbhs_omap"


Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)