linux-kernel - Re: [PATCH] MFD : add MAX77686 mfd driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120502085220.GC4075@opensource.wolfsonmicro.com>
Date:	Wed, 2 May 2012 09:52:21 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	jonghwa3.lee@...sung.com
Cc:	sameo@...ux.intel.com, linux-kernel@...r.kernel.org,
	cw00.choi@...sung.com, Chiwoong byun <woong.byun@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	MyungJoo Ham <myungjoo.ham@...sung.com>
Subject: Re: [PATCH] MFD : add MAX77686 mfd driver

On Wed, May 02, 2012 at 02:01:16PM +0900, jonghwa3.lee@...sung.com wrote:
> Hi Mark,
> 
> You point out many things. ;-) Thanks for your concern.
> I want to explain one by one.

Don't top post!  http://daringfireball.net/2007/07/on_top

> 2. Those steps is needed for wake-up interrupt occurred by 77686 irq.
>    When system has woken up from Suspend-to-RAM state by 77686 irq,
> 	then it never call irq handler.

Why?  Are you sure you aren't doing something like requesting the wrong
trigger type for the interrupt?

> 4. This will work when I2C interface is changed according to board
> 	revision with board configuration.

> 5. This is for some board that doesn't use RTC. (e.g. SMDK board)

Since you top posted I'm really not sure which comments you're referring
to with these...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)