linux-kernel - Re: [PATCH] MFD : add MAX77686 mfd driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120502092838.GA16327@andi>
Date:	Wed, 2 May 2012 11:28:38 +0200
From:	Andi Shyti <andi.shyti@...il.com>
To:	jonghwa3.lee@...sung.com
Cc:	sameo@...ux.intel.com, linux-kernel@...r.kernel.org,
	cw00.choi@...sung.com, Chiwoong byun <woong.byun@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	MyungJoo Ham <myungjoo.ham@...sung.com>
Subject: Re: [PATCH] MFD : add MAX77686 mfd driver

Hi,

On Wed, May 02, 2012 at 02:02:55PM +0900, jonghwa3.lee@...sung.com wrote:
> On 2012-04-30 18:17, Andi Shyti wrote:
> > Hi,
> > 
> >> +	mutex_lock(&max77686->iolock);
> >> +	ret = i2c_smbus_read_i2c_block_data(i2c, reg, count, buf);
> >> +	mutex_unlock(&max77686->iolock);
> > 
> > Is it relly necessay to lock whenever you read/write from/to the
> > i2c bus? Considering also that these are exported function,
> > someone else may lock here before, so we can have a double
> > locking on the same mutex.
> 
> These exported functions will be used in 77686 area only, so there is no
> overlap locking.

OK... I think this could be a reason more to not over-use mutexes :)

When you call i2c_smbus_* functions you are not accessing to any
private data, all the new data is allocated in a new area. The
smbus_xfer function should take care by himself that the global
data are locked correctly. If not, is not up to your driver to do
it.
If, instead, you are taking care about the concurrency in the
bus, this should be somehow managed by the chip itself.
In my opinion you are abusing a bit of mutex_lock/unlock.

Andi

P.S. copied and paste your reply at the bottom of my previous
comment.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/