linux-kernel - Re: [RFC PATCH v1 3/5] KVM: Add paravirt kvm_flush_tlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lilahep5.fsf@linux.vnet.ibm.com>
Date:	Wed, 02 May 2012 19:23:26 +0530
From:	Nikunj A Dadhania <nikunj@...ux.vnet.ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Avi Kivity <avi@...hat.com>, mingo@...e.hu, jeremy@...p.org,
	mtosatti@...hat.com, kvm@...r.kernel.org, x86@...nel.org,
	vatsa@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	hpa@...or.com
Subject: Re: [RFC PATCH v1 3/5] KVM: Add paravirt kvm_flush_tlb_others

On Wed, 02 May 2012 12:20:40 +0200, Peter Zijlstra <peterz@...radead.org> wrote:
> On Wed, 2012-05-02 at 14:21 +0530, Nikunj A Dadhania wrote:
> > [root@...1 linux]# grep HAVE_RCU_TABLE .config
> > CONFIG_HAVE_RCU_TABLE_FREE=y
> > [root@...1 linux]# make -j32  -s
> > mm/memory.c: In function ‘tlb_remove_table_one’:
> > mm/memory.c:315: error: implicit declaration of function ‘__tlb_remove_table’
> > 
> > I suppose we need to have __tlb_remove_table. Trying to understand what
> > needs to be done there. 
> 
> Argh, I really should get back to unifying all mmu-gather
> implementations :/
> 
> I think something like the below ought to sort it.
> 
Thanks a lot.

> Completely untested though..
> 

Tested-by: Nikunj A Dadhania <nikunj@...ux.vnet.ibm.com>

Here is the comparison with the other version. 

	Gang    pv_spin_flush    pv_spin_flush_rcu  
1VM     1.01       0.49            0.49     
2VMs    7.07       4.04            4.06     
4VMs    9.07       5.27            5.19     
8VMs    9.99       7.65            7.80     

Will test other use cases as well and report back.

Regards
Nikunj

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/