| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 May 2012 21:53:59 +0800 From: Shawn Guo <shawn.guo@...aro.org> To: Rob Lee <rob.lee@...aro.org> Cc: kernel@...gutronix.de, amit.kucheria@...aro.org, daniel.lezcano@...aro.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linaro-dev@...ts.linaro.org, patches@...aro.org, jj@...osbits.net Subject: Re: [PATCH v2 3/3] ARM: imx: Add imx6q cpuidle driver On Wed, May 02, 2012 at 08:50:20AM -0500, Rob Lee wrote: > >> --- a/arch/arm/mach-imx/mach-imx6q.c > >> +++ b/arch/arm/mach-imx/mach-imx6q.c > >> @@ -21,6 +21,9 @@ > >> #include <linux/of_platform.h> > >> #include <linux/phy.h> > >> #include <linux/micrel_phy.h> > >> +#include <linux/export.h> > >> +#include <linux/cpuidle.h> > >> +#include <asm/cpuidle.h> > >> #include <asm/smp_twd.h> > >> #include <asm/hardware/cache-l2x0.h> > >> #include <asm/hardware/gic.h> > >> @@ -29,6 +32,7 @@ > >> #include <asm/system_misc.h> > >> #include <mach/common.h> > >> #include <mach/hardware.h> > >> +#include <mach/cpuidle.h> > > > > The headers here are mostly sorted in names, so please ... > > > > Do you mean sorted alphabetically per group? So the last three > includes should look like this instead? > ... > #include <mach/common.h> > #include <mach/cpuidle.h> > #include <mach/hardware.h> > ... Yes. And do not forget <linux/export.h> and <linux/cpuidle.h>. -- Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists