linux-kernel - Re: [PATCH v6 1/3] trace: Make removal of ring buffer pages atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL26m8J8=-yvtW+7F+XqTKgZs4NxiT3gSYJFC3RetjBwJvzL2g@mail.gmail.com>
Date:	Thu, 3 May 2012 11:43:22 -0700
From:	Vaibhav Nagarnaik <vnagarnaik@...gle.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Laurent Chavey <chavey@...gle.com>,
	Justin Teravest <teravest@...gle.com>,
	David Sharp <dhsharp@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/3] trace: Make removal of ring buffer pages atomic

On Thu, May 3, 2012 at 7:12 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
> It's also giving me errors when I try to enable events or anything else
> when tracing_on is disabled.

Yes, I had to add a check to see if resizing is safe. I re-used
record_disabled in this patch for that purpose.

In the next patch for "atomic addition of pages" I added a new field
resize_disabled to guard against unsafe resizing. So with that patch,
you won't see this behavior. It also fixes the issue with trace-cmd
where the ring buffer doesn't get expanded.



Vaibhav Nagarnaik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/