linux-kernel - Re: [PATCH v6 1/3] trace: Make removal of ring buffer pages atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 May 2012 14:54:05 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Vaibhav Nagarnaik <vnagarnaik@...gle.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Laurent Chavey <chavey@...gle.com>,
	Justin Teravest <teravest@...gle.com>,
	David Sharp <dhsharp@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/3] trace: Make removal of ring buffer pages atomic

On Thu, 2012-05-03 at 11:43 -0700, Vaibhav Nagarnaik wrote:
> On Thu, May 3, 2012 at 7:12 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
> > It's also giving me errors when I try to enable events or anything else
> > when tracing_on is disabled.
> 
> Yes, I had to add a check to see if resizing is safe. I re-used
> record_disabled in this patch for that purpose.
> 
> In the next patch for "atomic addition of pages" I added a new field
> resize_disabled to guard against unsafe resizing. So with that patch,
> you won't see this behavior. It also fixes the issue with trace-cmd
> where the ring buffer doesn't get expanded.

Would it be possible to put that resize_disabled into the first patch so
we don't have this bug popping up in a git bisect?

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/