linux-kernel - Re: [PATCH 00/15] tools: Unify perf and trace-cmd trace event format parsing v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120507081424.GE16608@gmail.com>
Date:	Mon, 7 May 2012 10:14:24 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Borislav Petkov <bp@...en8.de>, Jiri Olsa <jolsa@...hat.com>,
	Arun Sharma <asharma@...com>,
	Namhyung Kim <namhyung.kim@....com>,
	Michael Rubin <mrubin@...gle.com>,
	David Sharp <dhsharp@...gle.com>,
	Vaibhav Nagarnaik <vnagarnaik@...gle.com>,
	Julia Lawall <julia@...u.dk>, Tom Zanussi <tzanussi@...il.com>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 00/15] tools: Unify perf and trace-cmd trace event format
 parsing v3


* Frederic Weisbecker <fweisbec@...il.com> wrote:

> Hi,
> 
> This is essentially a rebase against latest tip:perf/core updates.
> Mostly due to conflicts against the perf Makefile updates.
> 
> I think we all agree that this library needs improvements but these
> should rather be done incrementally. The current perf trace event parsing
> is anyway much backward compared to that library.
> 
> Default target is a static library in tools/libtraceevent/libtraceevent.a
> 
> This can be pulled from:
> 
> git://github.com/fweisbec/tracing.git
> 	perf/parse-events-4

It gives me:

/home/mingo/tip/tools/lib/traceevent/parse-filter.c: In function ‘create_arg_item’:
/home/mingo/tip/tools/lib/traceevent/parse-filter.c:343:9: warning: comparison between ‘enum filter_arg_type’ and ‘enum event_type’ [-Wenum-compare]
/home/mingo/tip/tools/lib/traceevent/parse-filter.c:339:2: warning: case value ‘8’ not in enumerated type ‘enum filter_arg_type’ [-Wswitch]

Had this been in tools/perf/ it would use -Werror already and 
you'd have fixed it, not requiring me to unpull these bits :-/

So can we please make a libevent.so, built sanely within 
tools/perf/lib/ or such and distributed together with perf so 
that the two can never get out of sync?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/