linux-kernel - Re: [PATCH 3/3] tty_lock: Localise the lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120507171126.5beddc27@pyramind.ukuu.org.uk>
Date:	Mon, 7 May 2012 17:11:26 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Sasha Levin <levinsasha928@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 3/3] tty_lock: Localise the lock

> I don't believe that this change is correct.
> 
> Consider the following scenario:
> 
> tty_release -> tty_lock -> pty_close -> tty_vhangup -> tty_lock

We hang up tty->link not tty.

It's now a per tty lock. So I think we are ok.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/