linux-kernel - [PATCH 0/3] scsi: usb-storage: hide errors for five devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1336472346.1933.52.camel@x61.thuisdomein>
Date:	Tue, 08 May 2012 12:19:06 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Matthew Dharm <mdharm-usb@...-eyed-alien.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-scsi@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 0/3] scsi: usb-storage: hide errors for five devices

0) Five USB memory sticks I happen to have will generate sets of two
errors when inserted. These sets are either:
    [...] Asking for cache data failed
    [...] Assuming drive cache: write through

or:
    [...] No Caching mode page present
    [...] Assuming drive cache: write through

These errors are generated by the SCSI stack (and printed thrice).

1) These patches try to hide those errors by:
- downgrading one error to a notice; and
- setting the NO_WP_DETECT quirk for these five devices.

2) Review of these patches is appreciated. Please note that the first
patch downgrades the error also for code paths that I apparently never
trigger, so that one especially needs additional thought, testing, etc.
 
3) It's not entirely clear which names one should use in the
UNUSUAL_DEV() macro. I just picked the most neutral names that showed up
for the devices in the logs.

4) Tested on v3.3.4, but applies cleanly to v3.4-rc6.

Paul Bolle (3):
  scsi: downgrade "write through" error to notice
  usb-storage: use NO_WP_DETECT for two devices
  usb-storage: use NO_WP_DETECT for three devices

 drivers/scsi/sd.c                  |    2 +-
 drivers/usb/storage/unusual_devs.h |   22 ++++++++++++++++++++--
 2 files changed, 21 insertions(+), 3 deletions(-)

-- 
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/