linux-kernel - Re: [PATCH 0/3] scsi: usb-storage: hide errors for five devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1205081000250.1479-100000@iolanthe.rowland.org>
Date:	Tue, 8 May 2012 10:02:31 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Paul Bolle <pebolle@...cali.nl>
cc:	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Matthew Dharm <mdharm-usb@...-eyed-alien.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-scsi@...r.kernel.org>,
	<usb-storage@...ts.one-eyed-alien.net>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] scsi: usb-storage: hide errors for five devices

On Tue, 8 May 2012, Paul Bolle wrote:

> 0) Five USB memory sticks I happen to have will generate sets of two
> errors when inserted. These sets are either:
>     [...] Asking for cache data failed
>     [...] Assuming drive cache: write through
> 
> or:
>     [...] No Caching mode page present
>     [...] Assuming drive cache: write through
> 
> These errors are generated by the SCSI stack (and printed thrice).
> 
> 1) These patches try to hide those errors by:
> - downgrading one error to a notice; and

That's a reasonable thing to do, IMO.

> - setting the NO_WP_DETECT quirk for these five devices.

But that isn't.  These quirks are intended for devices that crash when
they receive the command in question.  They aren't meant to suppress
sending commands to devices that can properly reject them.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/