linux-kernel - Re: [PATCH v3 4/7] x86/tlb: add tlb flush all factor for specific CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FA937C0.7080202@zytor.com>
Date:	Tue, 08 May 2012 08:12:00 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Alex Shi <alex.shi@...el.com>
CC:	mgorman@...e.de, npiggin@...il.com, tglx@...utronix.de,
	mingo@...hat.com, arnd@...db.de, rostedt@...dmis.org,
	fweisbec@...il.com, jeremy@...p.org, gregkh@...uxfoundation.org,
	glommer@...hat.com, riel@...hat.com, luto@....edu, avi@...hat.com,
	len.brown@...el.com, dhowells@...hat.com, fenghua.yu@...el.com,
	borislav.petkov@....com, yinghai@...nel.org, ak@...ux.intel.com,
	cpw@....com, steiner@....com, akpm@...ux-foundation.org,
	penberg@...nel.org, hughd@...gle.com, rientjes@...gle.com,
	kosaki.motohiro@...fujitsu.com, n-horiguchi@...jp.nec.com,
	paul.gortmaker@...driver.com, trenn@...e.de, tj@...nel.org,
	oleg@...hat.com, axboe@...nel.dk, a.p.zijlstra@...llo.nl,
	kamezawa.hiroyu@...fujitsu.com, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/7] x86/tlb: add tlb flush all factor for specific
 CPUs

On 05/08/2012 07:03 AM, Alex Shi wrote:
> --- a/arch/x86/kernel/cpu/intel.c
> +++ b/arch/x86/kernel/cpu/intel.c
> @@ -610,6 +610,35 @@ void intel_tlb_lookup(const unsigned char desc)
>  	}
>  }
>  
> +void intel_tlb_flushall_factor_set(struct cpuinfo_x86 *c)
> +{
> +	switch (c->x86_model) {
> +	case 15: /* original 65 nm celeron/pentium/core2/xeon, "Merom"/"Conroe" */
> +		tlb_flushall_factor = 0;
> +		break;
> +	case 26: /* 45 nm nehalem, "Bloomfield" */
> +	case 30: /* 45 nm nehalem, "Lynnfield" */
> +	case 37: /* 32 nm nehalem, "Clarkdale" */
> +	case 44: /* 32 nm nehalem, "Gulftown" */
> +	case 46: /* 45 nm nehalem-ex, "Beckton" */
> +		tlb_flushall_factor = 64;
> +		break;
> +	case 42: /* SandyBridge */
> +	case 45: /* SandyBridge, "Romely-EP" */
> +		tlb_flushall_factor = 32;
> +		break;
> +	case 28: /* Atom */
> +	case 47: /* 32 nm Xeon E7 */
> +	case 14: /* 65 nm core solo/duo, "Yonah" */
> +	case 22: /* single-core 65 nm celeron/core2solo "Merom-L"/"Conroe-L" */
> +	case 23: /* current 45 nm celeron/core2/xeon "Penryn"/"Wolfdale" */
> +	case 29: /* six-core 45 nm xeon "Dunnington" */
> +
> +	default:
> +		tlb_flushall_factor = 0;
> +	}
> +}
> +

This uses x86_model without qualifying it x86 (family), however that is
meaningless.  All the CPUs you are dealing with above have c->x86 == 6,
but you need to handle others correctly (even if that just means
defaulting it to zero.)

One way to do that is to do:

switch ((c->x86 << 8) + c->x86_model) {

... and use numbers like 0x62d instead of 45.

	-hpa


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/