linux-kernel - Re: [PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120509065202.3b3b0436@notabene.brown>
Date:	Wed, 9 May 2012 06:52:02 +1000
From:	NeilBrown <neilb@...e.de>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Tony Lindgren <tony@...mide.com>,
	Russell King <linux@....linux.org.uk>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/3] IRQ: allow check_wakeup_irqs to notice
 level-triggered interrupts.

On Fri, 4 May 2012 18:01:22 +0200 (CEST) Thomas Gleixner <tglx@...utronix.de>
wrote:

> Neil,
> 
> On Fri, 4 May 2012, NeilBrown wrote:
> 
> > On Wed, 25 Apr 2012 14:54:54 +0200 (CEST) Thomas Gleixner
> > <tglx@...utronix.de> wrote:
> > 
> > > Why not simply managing the pending bit for level irqs ?
> > > 
> > 
> > Hi Thomas,
> >  thanks again for the patch.  I finally made time to test it and it works as
> > expected.  I've included it below with a change-log entry and tested-by:
> > in case that helps.
> 
> thanks for testing. The changelog is great. You know how to make the
> live of lazy buggers easier :)

Just buttering you up so any future patches slip past easily :-)

I think I'll need to ask for IRQS_PENDING to be set for nested interrupts too
but I'll be a little while before  I an look at that issue properly and
propose a patch.

Thanks for your help,
NeilBrown



>   
> >  	for_each_irq_desc(irq, desc) {
> > -		if (irqd_is_wakeup_set(&desc->irq_data)) {
> > +		if (desc->depth == 1 &&
> > +		    irqd_is_wakeup_set(&desc->irq_data)) {
> >  			if (desc->istate & IRQS_PENDING)
> >  				return -EBUSY;
> >  			continue;
> 
> I split that part into a separate patch, as it's really a different
> issue.
> 
> Thanks,
> 
> 	tglx


Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)