lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 May 2012 23:04:00 +0200 From: "Rafael J. Wysocki" <rjw@...k.pl> To: Colin Cross <ccross@...roid.com> Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-pm@...ts.linux-foundation.org, Kevin Hilman <khilman@...com>, Len Brown <len.brown@...el.com>, Trinabh Gupta <g.trinabh@...il.com>, Arjan van de Ven <arjan@...ux.intel.com>, Deepthi Dharwar <deepthi@...ux.vnet.ibm.com>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, Kay Sievers <kay.sievers@...y.org>, Santosh Shilimkar <santosh.shilimkar@...com>, Daniel Lezcano <daniel.lezcano@...aro.org>, Amit Kucheria <amit.kucheria@...aro.org>, Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Arnd Bergmann <arnd.bergmann@...aro.org>, Russell King <linux@....linux.org.uk> Subject: Re: [PATCHv4 2/4] cpuidle: fix error handling in __cpuidle_register_device On Tuesday, May 08, 2012, Colin Cross wrote: > Fix the error handling in __cpuidle_register_device to include > the missing list_del. Move it to a label, which will simplify > the error handling when coupled states are added. > > Reviewed-by: Santosh Shilimkar <santosh.shilimkar@...com> > Tested-by: Santosh Shilimkar <santosh.shilimkar@...com> > Reviewed-by: Kevin Hilman <khilman@...com> > Tested-by: Kevin Hilman <khilman@...com> > Signed-off-by: Colin Cross <ccross@...roid.com> I've said Reviewed-by: Rafael J. Wysocki <rjw@...k.pl> to this already too. Rafael > --- > drivers/cpuidle/cpuidle.c | 13 +++++++++---- > 1 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c > index 3e3e3e4..4540672 100644 > --- a/drivers/cpuidle/cpuidle.c > +++ b/drivers/cpuidle/cpuidle.c > @@ -403,13 +403,18 @@ static int __cpuidle_register_device(struct cpuidle_device *dev) > > per_cpu(cpuidle_devices, dev->cpu) = dev; > list_add(&dev->device_list, &cpuidle_detected_devices); > - if ((ret = cpuidle_add_sysfs(cpu_dev))) { > - module_put(cpuidle_driver->owner); > - return ret; > - } > + ret = cpuidle_add_sysfs(cpu_dev); > + if (ret) > + goto err_sysfs; > > dev->registered = 1; > return 0; > + > +err_sysfs: > + list_del(&dev->device_list); > + per_cpu(cpuidle_devices, dev->cpu) = NULL; > + module_put(cpuidle_driver->owner); > + return ret; > } > > /** > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists