linux-kernel - Re: [PATCH 2/2] irq: use config_enabled(SMP) checks to cleanup irq_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 May 2012 09:50:31 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, joerg.roedel@....com,
	paul.gortmaker@...driver.com, Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH 2/2] irq: use config_enabled(SMP) checks to cleanup
 irq_set_affinity() for UP


* Suresh Siddha <suresh.b.siddha@...el.com> wrote:

> On Wed, 2012-05-09 at 11:46 -0700, Suresh Siddha wrote:
> > Use config_enabled(SMP) checks for cleaning up the ifdef CONFIG_SMP around
> > irq_set_affinity routines in io_apic and irq_remapping subsystems.
> > 
> 
> Switched to IS_BUILTIN() instead. Thanks.

Hm, what was wrong with config_enabled(CONFIG_SMP)?

The IS_BUILTIN() macro is 1) shouting loud, needlessly 2) 
somewhat confusing for the CONFIG_SMP case: of course SMP is 
'built in', not modular - and the fact that 'built in' also 
implies 'enabled' is lost in that naming variant.

So I think IS_BUILTIN() makes more sense for genuine tri-state 
config knobs, and bools like CONFIG_SMP should se 
config_enabled()..

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/