linux-kernel - Re: [PATCH 1/2] kconfig: change config_enabled() to accept X instead of CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVbWNC0=qFTfwoP-_N6b-MfOX63v0931HOpLcnfBRMt2Q@mail.gmail.com>
Date:	Thu, 10 May 2012 08:05:31 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Suresh Siddha <suresh.b.siddha@...el.com>, mingo@...nel.org,
	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, joerg.roedel@....com,
	paul.gortmaker@...driver.com
Subject: Re: [PATCH 1/2] kconfig: change config_enabled() to accept X instead
 of CONFIG_X

On Wed, May 9, 2012 at 8:56 PM, Sam Ravnborg <sam@...nborg.org> wrote:
> On Wed, May 09, 2012 at 11:46:35AM -0700, Suresh Siddha wrote:
>> change config_enabled() to use it as config_enabled(SMP) instead of
>> config_enabled(CONFIG_SMP).
>
> You are breaking all existing users.
> And CONFIG_ was included to allow better grepability.

Indeed.

> If you insist on having a CONFIG less variant
> introduce a new variant for this.

It's already bad enough that you have to use
`git grep -w FOO $(git ls-files "*Kconf*")` [*] to find the non-prefixed
symbols in the Kconfig logic, followed by `git grep -w CONFIG_FOO`
for the rest.

[*] Doh, recently I discovered that `git grep -w FOO -- "*Kconf*"' also
works, but my fingers are not yet used to it...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/