lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 May 2012 12:34:14 -0500 From: H Hartley Sweeten <hartleys@...ionengravers.com> To: Ian Abbott <abbotti@....co.uk> CC: Linux Kernel <linux-kernel@...r.kernel.org>, "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>, Ian Abbott <ian.abbott@....co.uk>, "fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org> Subject: RE: [PATCH] staging: comedi: Add helper macro for comedi pci driver boilerplate On Friday, May 11, 2012 10:32 AM, Ian Abbott wrote: > On 2012-05-11 18:07, H Hartley Sweeten wrote: >> +int comedi_pci_driver_register(struct comedi_driver *comedi_driver, >> + struct pci_driver *pci_driver) >> +{ >> + int ret; >> + >> + ret = comedi_driver_register(comedi_driver); >> + if (ret< 0) >> + return ret; >> + >> + pci_driver->name = comedi_driver->driver_name; > > I think it would be better if the driver modules that call this function > already had pci_driver->name initialized statically. I agree, but this is how all the pci drivers do it now. To change this will require auditing all the comedi pci drivers and adding the static name. Regards, Hartley
Powered by blists - more mailing lists