linux-kernel - Re: [PATCH 4/4] gpio: tps65910: move this as platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 May 2012 11:40:11 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Laxman Dewangan <ldewangan@...dia.com>,
	linus.walleij@...ricsson.com, sameo@...ux.intel.com,
	broonie@...nsource.wolfsonmicro.com, jedu@...mlogic.co.uk,
	lrg@...mlogic.co.uk
Cc:	linux-kernel@...r.kernel.org,
	Laxman Dewangan <ldewangan@...dia.com>
Subject: Re: [PATCH 4/4] gpio: tps65910: move this as platform driver

On Wed,  9 May 2012 18:40:57 +0530, Laxman Dewangan <ldewangan@...dia.com> wrote:
> Make the gpio-tps65910 as platform driver and register
> this from tps65910 core driver as mfd sub device.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>

Minor comment below, but otherwise:

Acked-by: Grant Likely <grant.likely@...retlab.ca>
> +static struct platform_driver tps65910_gpio_driver = {
> +	.driver.name    = "tps65910-gpio",
> +	.driver.owner   = THIS_MODULE,
> +	.probe		= tps65910_gpio_probe,
> +	.remove		= __devexit_p(tps65910_gpio_remove),
> +};
> +
> +static int __init tps65910_gpio_init(void)
> +{
> +	return platform_driver_register(&tps65910_gpio_driver);
> +}
> +subsys_initcall(tps65910_gpio_init);
> +
> +static void __exit tps65910_gpio_exit(void)
> +{
> +	platform_driver_unregister(&tps65910_gpio_driver);
> +}
> +module_exit(tps65910_gpio_exit);

module_platform_driver()

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/