linux-kernel - Re: [PATCH 4/4] gpio: tps65910: move this as platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120511190844.GA29835@opensource.wolfsonmicro.com>
Date:	Fri, 11 May 2012 20:08:45 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	Laxman Dewangan <ldewangan@...dia.com>,
	linus.walleij@...ricsson.com, sameo@...ux.intel.com,
	jedu@...mlogic.co.uk, lrg@...mlogic.co.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] gpio: tps65910: move this as platform driver

On Fri, May 11, 2012 at 11:40:11AM -0600, Grant Likely wrote:
> > +static int __init tps65910_gpio_init(void)
> > +{
> > +	return platform_driver_register(&tps65910_gpio_driver);
> > +}
> > +subsys_initcall(tps65910_gpio_init);

> module_platform_driver()

This seems a little premature when we've not got many (any?) drivers
implementing -EPROBE_DEFER.  If we got the change I posted to make
gpio_request() return -EPROBE_DEFER if there was no GPIO registered
that'd get most cases covered though, the drivers would hopefully pass
the error through.

I've not done this for regulators since the cpufreq drivers are still
deviceless so couldn't cope.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)