linux-kernel - Re: [PATCH V3 2/2] gpio: add STA2X11 GPIO block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120514100813.GN31985@opensource.wolfsonmicro.com>
Date:	Mon, 14 May 2012 11:08:13 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Alessandro Rubini <rubini@...dd.com>
Cc:	grant.likely@...retlab.ca, linux-kernel@...r.kernel.org,
	giancarlo.asnaghi@...com, alan@...ux.intel.com,
	sameo@...ux.intel.com, linus.walleij@...ricsson.com
Subject: Re: [PATCH V3 2/2] gpio: add STA2X11 GPIO block

On Mon, May 14, 2012 at 12:06:45PM +0200, Alessandro Rubini wrote:

> > If you use platform data why would you get unpredicatable numbers?

> Because I request the irq numbers from the gpio driver (now I request
> a free slot starting from 384, because previous drivers had it
> hardwired).  So if the gpio driver requests a slot starting from 0 it
> may get different values -- in general I can't now what it gets.

But this is because you're not using platform data!  If you use platform
data to tell all the drivers including the gpio driver which ranges to
use then this problem does not exist.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)