linux-kernel - Re: [PATCH V3 2/2] gpio: add STA2X11 GPIO block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120514100645.GA5712@mail.gnudd.com>
Date:	Mon, 14 May 2012 12:06:45 +0200
From:	Alessandro Rubini <rubini@...dd.com>
To:	broonie@...nsource.wolfsonmicro.com
Cc:	grant.likely@...retlab.ca, linux-kernel@...r.kernel.org,
	giancarlo.asnaghi@...com, alan@...ux.intel.com,
	sameo@...ux.intel.com, linus.walleij@...ricsson.com
Subject: Re: [PATCH V3 2/2] gpio: add STA2X11 GPIO block

> If you use platform data why would you get unpredicatable numbers?

Because I request the irq numbers from the gpio driver (now I request
a free slot starting from 384, because previous drivers had it
hardwired).  So if the gpio driver requests a slot starting from 0 it
may get different values -- in general I can't now what it gets.

So the irq number is unknown at compile time, and can't be written in
the platform data.

Actually, the problem is there in any case if you plug two chips in
the same computer -- this is extremely unlikely because the sta2x11 is
currently only used as a motherboard chipset.  The thing must be
fixed in any case, because it's a pci device, but still using 384
allows me to use platform data for the current drivers that I'm running
until they are ported to upstream quality standards.

/alessandro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/