linux-kernel - Re: [PATCH V3 2/2] gpio: add STA2X11 GPIO block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120514095800.GL31985@opensource.wolfsonmicro.com>
Date:	Mon, 14 May 2012 10:58:01 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Alessandro Rubini <rubini@...dd.com>
Cc:	grant.likely@...retlab.ca, linux-kernel@...r.kernel.org,
	giancarlo.asnaghi@...com, alan@...ux.intel.com,
	sameo@...ux.intel.com, linus.walleij@...ricsson.com
Subject: Re: [PATCH V3 2/2] gpio: add STA2X11 GPIO block

On Mon, May 14, 2012 at 11:51:11AM +0200, Alessandro Rubini wrote:
> Me:
> >> I'm not completely clear (yet) about how to get the right interrupt
> >> number in those other drivers, but I'm willing to remove the constraint
> >> as they are cleaned up and submitted.

> Mark Brown:
> > Use platform data for both this driver and the other drivers (or device
> > tree if you're doing that).  This will hard code the magic numbers in
> > the board files, not in the driver.

> Yes, but it's not that easy. If the gpio driver gets unpredictable
> interrupt numbers associated to the pins, the other drivers must
> recover those numbers in some way.  That's why I currently started
> from 384, like the prevoous gpio driver was doing: the platform data
> uses that knowledge in the drivers I'm still using internally (but are
> not submittable as-is, so I'm working on them).

If you use platform data why would you get unpredicatable numbers?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)