linux-kernel - Re: [PATCH v3 2/2] MFD: MAX77693: add IRQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120514095719.GK31985@opensource.wolfsonmicro.com>
Date:	Mon, 14 May 2012 10:57:20 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	sameo@...ux.intel.com, myungjoo.ham@...sung.com,
	kyungmin.park@...sung.com, jonghwa3.lee@...sung.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] MFD: MAX77693: add IRQ handler

On Mon, May 14, 2012 at 02:20:35PM +0900, Chanwoo Choi wrote:

> +	if (!max77693->irq) {
> +		dev_warn(max77693->dev, "No interrupt specified.\n");
> +		return 0;
> +	}

I'd suggest just setting up the IRQ domain anyway - it makes life
simpler in the other drivers for the chip as they don't need to worry if
interrupts are registered unless it's very important to them that they
go off which is often not the case.  Just skip actually claiming the
IRQ.

> +EXPORT_SYMBOL_GPL(max77693_irq_resume);
> +EXPORT_SYMBOL_GPL(max77693_irq_init);
> +EXPORT_SYMBOL_GPL(max77693_irq_exit);

These shouldn't need to be exported, they're only used by the MFD core.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)