linux-kernel - Re: [PATCH v3 2/2] MFD: MAX77693: add IRQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4FB0D93A.7000108@samsung.com>
Date:	Mon, 14 May 2012 19:06:50 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	sameo@...ux.intel.com, myungjoo.ham@...sung.com,
	kyungmin.park@...sung.com, jonghwa3.lee@...sung.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] MFD: MAX77693: add IRQ handler

Hi Mark,

On 05/14/2012 06:57 PM, Mark Brown wrote:

> On Mon, May 14, 2012 at 02:20:35PM +0900, Chanwoo Choi wrote:
> 
>> +	if (!max77693->irq) {
>> +		dev_warn(max77693->dev, "No interrupt specified.\n");
>> +		return 0;
>> +	}
> 
> I'd suggest just setting up the IRQ domain anyway - it makes life
> simpler in the other drivers for the chip as they don't need to worry if
> interrupts are registered unless it's very important to them that they
> go off which is often not the case.  Just skip actually claiming the
> IRQ.
> 

This patch add support irq domain for MAX77693 in the
max77693_irq_init() function.
You can check on patchset. Then, The 'max77693->irq' is gpio pin for
IRQ. max77693->irq
is meant to indicate to the application processor that the status of
MAX77693 has changed.

>> +EXPORT_SYMBOL_GPL(max77693_irq_resume);
>> +EXPORT_SYMBOL_GPL(max77693_irq_init);
>> +EXPORT_SYMBOL_GPL(max77693_irq_exit);
> 
> These shouldn't need to be exported, they're only used by the MFD core.

OK, I remove it.

Thank you,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/