linux-kernel - Re: [PATCH v3 2/2] MFD: MAX77693: add IRQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120514101626.GO31985@opensource.wolfsonmicro.com>
Date:	Mon, 14 May 2012 11:16:27 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	sameo@...ux.intel.com, myungjoo.ham@...sung.com,
	kyungmin.park@...sung.com, jonghwa3.lee@...sung.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] MFD: MAX77693: add IRQ handler

On Mon, May 14, 2012 at 07:06:50PM +0900, Chanwoo Choi wrote:
> On 05/14/2012 06:57 PM, Mark Brown wrote:
> > On Mon, May 14, 2012 at 02:20:35PM +0900, Chanwoo Choi wrote:

> >> +	if (!max77693->irq) {
> >> +		dev_warn(max77693->dev, "No interrupt specified.\n");
> >> +		return 0;
> >> +	}

> > I'd suggest just setting up the IRQ domain anyway - it makes life
> > simpler in the other drivers for the chip as they don't need to worry if
> > interrupts are registered unless it's very important to them that they
> > go off which is often not the case.  Just skip actually claiming the
> > IRQ.

> This patch add support irq domain for MAX77693 in the
> max77693_irq_init() function.
> You can check on patchset. Then, The 'max77693->irq' is gpio pin for
> IRQ. max77693->irq
> is meant to indicate to the application processor that the status of
> MAX77693 has changed.

Sure.  What I'm saying is that it's probably going to be easier all
round if you run through all the init except actually calling
request_threaded_irq() (and unmasking the external interrupt if you have
control of that) - that way the interrupt numbers for the interrupts on
the PMIC can always be requested, even if they can't actually occur.
Only child drivers that *really* need the interrupts to happen will need
to have conditional code.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)