linux-kernel - Re: [PATCH 1/5] Staging ipack: fix a few sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120514122628.GH16984@mwanda>
Date:	Mon, 14 May 2012 15:26:28 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Samuel Iglesias Gonsalvez <siglesias@...lia.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] Staging ipack: fix a few sparse warnings

On Mon, May 14, 2012 at 12:41:25PM +0200, Samuel Iglesias Gonsalvez wrote:
>  	/* Read status register */
> -	status_reg = readw((unsigned short *) (tpci200->info->interface_regs +
> +	status_reg = readw((void __iomem *) (tpci200->info->interface_regs +
>  					       TPCI200_STATUS_REG));
>  

Later in the patch, you do the right thing which is to declare this
as an __iomem pointer in the header.  The cast here can be removed
and it all fits on one line.

Remove it in a follow on patch if you want.  Same for several of the
other casts in this patch.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/