linux-kernel - Re: [PATCH 1/5] Staging ipack: fix a few sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337000016.3438.5.camel@fourier.local.igalia.com>
Date:	Mon, 14 May 2012 14:53:36 +0200
From:	Samuel Iglesias Gonsálvez 
	<siglesias@...lia.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] Staging ipack: fix a few sparse warnings

On Mon, 2012-05-14 at 15:26 +0300, Dan Carpenter wrote:
> On Mon, May 14, 2012 at 12:41:25PM +0200, Samuel Iglesias Gonsalvez wrote:
> >  	/* Read status register */
> > -	status_reg = readw((unsigned short *) (tpci200->info->interface_regs +
> > +	status_reg = readw((void __iomem *) (tpci200->info->interface_regs +
> >  					       TPCI200_STATUS_REG));
> >  
> 
> Later in the patch, you do the right thing which is to declare this
> as an __iomem pointer in the header.  The cast here can be removed
> and it all fits on one line.
> 
> Remove it in a follow on patch if you want.  Same for several of the
> other casts in this patch.

Thanks a lot. I will do it.

Regards,

Sam



Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)