linux-kernel - Re: [PATCH 2/5] Staging: ipack: add proper device model into ipack_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120514204654.GA8723@kroah.com>
Date:	Mon, 14 May 2012 13:46:54 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Samuel Iglesias Gonsalvez <siglesias@...lia.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] Staging: ipack: add proper device model into
 ipack_bus_register.

On Mon, May 14, 2012 at 12:41:26PM +0200, Samuel Iglesias Gonsalvez wrote:
> This patch adds a proper device model to the driver. The carrier boards are
> managed like other ipack device, the way to recognize them is using the
> platform data field from struct device.

Wait, what?  Why would you use the platform data field?  Why is that
needed at all?  You can specify the "type" of the device, but it seems
that you really want two different things here, busses and devices,
right?  So use two different devices and manage them differently, don't
make them the "same but different" by looking at the platform data
field.  That's not what the platform data field is for at all, sorry.

Please rework this patch, I can't take it as-is, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/