linux-kernel - Re: [PATCH RESEND] x86: kernel/check.c simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337007700.2476.1.camel@lorien2>
Date:	Mon, 14 May 2012 09:01:40 -0600
From:	Shuah Khan <shuahkhan@...il.com>
To:	mingo@...hat.com
Cc:	shuahkhan@...il.com, hpa@...or.com, tglx@...utronix.de,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] x86: kernel/check.c simple_strtoul cleanup

On Sun, 2012-05-06 at 11:55 -0600, Shuah Khan wrote:
> Change set_corruption_check() and set_corruption_check_period()
> in kernel/check.c to call kstrtoul() instead of calling
> obsoleted simple_strtoul().

How about this patch? Are you not interested in this type of cleanup
patches? Looking for some feedback so I can spend my energies on
something that would be worth while in the future :)

-- Shuah
> 
> 
> Signed-off-by: Shuah Khan <shuahkhan@...il.com>
> ---
>  arch/x86/kernel/check.c |   20 ++++++++++++++------
>  1 files changed, 14 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/x86/kernel/check.c b/arch/x86/kernel/check.c
> index 5da1269..e2dbcb7 100644
> --- a/arch/x86/kernel/check.c
> +++ b/arch/x86/kernel/check.c
> @@ -27,21 +27,29 @@ static int num_scan_areas;
>  
>  static __init int set_corruption_check(char *arg)
>  {
> -	char *end;
> +	ssize_t ret;
> +	unsigned long val;
>  
> -	memory_corruption_check = simple_strtol(arg, &end, 10);
> +	ret = kstrtoul(arg, 10, &val);
> +	if (ret)
> +		return ret;
>  
> -	return (*end == 0) ? 0 : -EINVAL;
> +	memory_corruption_check = val;
> +	return 0;
>  }
>  early_param("memory_corruption_check", set_corruption_check);
>  
>  static __init int set_corruption_check_period(char *arg)
>  {
> -	char *end;
> +	ssize_t ret;
> +	unsigned long val;
>  
> -	corruption_check_period = simple_strtoul(arg, &end, 10);
> +	ret = kstrtoul(arg, 10, &val);
> +	if (ret)
> +		return ret;
>  
> -	return (*end == 0) ? 0 : -EINVAL;
> +	corruption_check_period = val;
> +	return 0;
>  }
>  early_param("memory_corruption_check_period", set_corruption_check_period);
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/