linux-kernel - Re: [PATCH RESEND] x86: kernel/dumpstack.c simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 May 2012 09:02:27 -0600
From:	Shuah Khan <shuahkhan@...il.com>
To:	mingo@...hat.com
Cc:	shuahkhan@...il.com, hpa@...or.com, tglx@...utronix.de,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] x86: kernel/dumpstack.c simple_strtoul cleanup

On Sun, 2012-05-06 at 11:58 -0600, Shuah Khan wrote:
> Change kstack_setup() and code_bytes_setup() in kernel/dumpstack.c
> to call kstrtoul() instead of calling obsoleted simple_strtoul().
> 
How about this patch? Are you not interested in this type of cleanup
patches? Looking for some feedback so I can spend my energies on 
something that would be worth while :)

-- Shuah
> 
> Signed-off-by: Shuah Khan <shuahkhan@...il.com>
> ---
>  arch/x86/kernel/dumpstack.c |   21 +++++++++++++++++++--
>  1 files changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
> index 1b81839..b154f6d 100644
> --- a/arch/x86/kernel/dumpstack.c
> +++ b/arch/x86/kernel/dumpstack.c
> @@ -311,16 +311,33 @@ void die(const char *str, struct pt_regs *regs, long err)
>  
>  static int __init kstack_setup(char *s)
>  {
> +	ssize_t ret;
> +	unsigned long val;
> +
>  	if (!s)
>  		return -EINVAL;
> -	kstack_depth_to_print = simple_strtoul(s, NULL, 0);
> +
> +	ret = kstrtoul(s, 0, &val);
> +	if (ret)
> +		return ret;
> +	kstack_depth_to_print = val;
>  	return 0;
>  }
>  early_param("kstack", kstack_setup);
>  
>  static int __init code_bytes_setup(char *s)
>  {
> -	code_bytes = simple_strtoul(s, NULL, 0);
> +	ssize_t ret;
> +	unsigned long val;
> +
> +	if (!s)
> +		return -EINVAL;
> +
> +	ret = kstrtoul(s, 0, &val);
> +	if (ret)
> +		return ret;
> +
> +	code_bytes = val;
>  	if (code_bytes > 8192)
>  		code_bytes = 8192;
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/