linux-kernel - Re: [PATCH v2 2/2] Extcon: MAX8997: Add support irq domain for MAX8997 muic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 May 2012 09:13:19 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	broonie@...nsource.wolfsonmicro.com, thomas.abraham@...aro.org,
	grant.likely@...retlab.ca, sameo@...ux.intel.com,
	myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
	jonghwa3.lee@...sung.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] Extcon: MAX8997: Add support irq domain for
 MAX8997 muic

On Fri, May 11, 2012 at 10:10:21AM +0900, Chanwoo Choi wrote:
> This patch add support irq domain for Maxim MAX8997 muic
> instead of irq_base in platform data and max8997 driver
> private data are instead. It is tested on TRATS board.
> 
> v2
> - Fix typo when free_irq() in max8997_muic_probe()
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> Signed-off-by: Myungjoo Ham <myungjoo.ham@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> ---
>  drivers/extcon/extcon-max8997.c |   28 +++++++++++++++++-----------
>  1 files changed, 17 insertions(+), 11 deletions(-)

This patch breaks the build on my system:

  CC [M]  drivers/extcon/extcon-max8997.o
drivers/extcon/extcon-max8997.c: In function ‘max8997_muic_probe’:
drivers/extcon/extcon-max8997.c:456:3: error: implicit declaration of function ‘irq_create_mapping’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

So I can't accept these two patches, sorry.  Please fix this up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/