linux-kernel - [PATCH] HID: wacom: Remove raport header check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 14 May 2012 17:13:26 +0100
From:	Przemo Firszt <przemo@...szt.eu>
To:	pinglinux@...il.com, jkosina@...e.cz
Cc:	linuxwacom-devel@...ts.sourceforge.net,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Przemo Firszt <przemo@...szt.eu>
Subject: [PATCH] HID: wacom: Remove raport header check.

That check was valid when hid-wacom was only supporting Wacom Graphire, as the
device raports always start with 0x03. Intuos4 WL high-speed raports
begin with 0x04, so the check would be filtering out valid reports.

Signed-off-by: Przemo Firszt <przemo@...szt.eu>
---
 drivers/hid/hid-wacom.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
index 29372ed..324ea74 100644
--- a/drivers/hid/hid-wacom.c
+++ b/drivers/hid/hid-wacom.c
@@ -578,10 +578,6 @@ static int wacom_raw_event(struct hid_device *hdev, struct hid_report *report,
 	hidinput = list_entry(hdev->inputs.next, struct hid_input, list);
 	input = hidinput->input;
 
-	/* Check if this is a tablet report */
-	if (data[0] != 0x03)
-		return 0;
-
 	switch (hdev->product) {
 	case USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH:
 		return wacom_gr_parse_report(hdev, wdata, input, data);
-- 
1.7.10.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/