linux-kernel - Re: [PATCH 2/3] zram: remove comment in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 May 2012 08:55:16 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Seth Jennings <sjenning@...ux.vnet.ibm.com>,
	Nitin Gupta <ngupta@...are.org>,
	Dan Magenheimer <dan.magenheimer@...cle.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 2/3] zram: remove comment in Kconfig

On Tue, May 15, 2012 at 11:31:24AM +0900, Minchan Kim wrote:
> On 05/14/2012 11:42 PM, Seth Jennings wrote:
> 
> > On 05/14/2012 03:45 AM, Minchan Kim wrote:
> > 
> >> Exactly speaking, zram should has dependency with
> >> zsmalloc, not x86. So x86 dependeny check is redundant.
> >>
> >> Signed-off-by: Minchan Kim <minchan@...nel.org>
> >> ---
> >>  drivers/staging/zram/Kconfig |    4 +---
> >>  1 file changed, 1 insertion(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/staging/zram/Kconfig b/drivers/staging/zram/Kconfig
> >> index 9d11a4c..ee23a86 100644
> >> --- a/drivers/staging/zram/Kconfig
> >> +++ b/drivers/staging/zram/Kconfig
> >> @@ -1,8 +1,6 @@
> >>  config ZRAM
> >>  	tristate "Compressed RAM block device support"
> >> -	# X86 dependency is because zsmalloc uses non-portable pte/tlb
> >> -	# functions
> >> -	depends on BLOCK && SYSFS && X86
> >> +	depends on BLOCK && SYSFS
> > 
> > 
> > Two comments here:
> > 
> > 1) zram should really depend on ZSMALLOC instead of selecting it
> > because, as the patch has it, zram could be selected on an arch that
> > zsmalloc doesn't support.
> 
> 
> Argh, Totally my mistake. my patch didn't match with my comment, either. :(
> 
> > 
> > 2) This change would need to be done in zcache as well.
> 
> 
> I see.
> Seth, Thanks.
> 
> send v2.

It's all messed up with tabs and spaces, care to resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/