linux-kernel - Re: [PATCH 2/3] zram: remove comment in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPbh3rvOKvo5cxVR5f35xAmzJ_uoR+SO2dzoJzvLi4mMnm-DZQ@mail.gmail.com>
Date:	Tue, 15 May 2012 10:37:19 -0400
From:	Konrad Rzeszutek Wilk <konrad@...nok.org>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Seth Jennings <sjenning@...ux.vnet.ibm.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Nitin Gupta <ngupta@...are.org>,
	Dan Magenheimer <dan.magenheimer@...cle.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 2/3] zram: remove comment in Kconfig

>
> == CUT_HERE ==
>
> >From be81aec5a4f35139aae2bf3d18139fbc114897ca Mon Sep 17 00:00:00 2001
> From: Minchan Kim <minchan@...nel.org>
> Date: Tue, 15 May 2012 11:26:48 +0900
> Subject: [PATCH] [zram,zcache] remove dependency with x86
>
> Exactly saying, [zram|zcache] should has a dependency with
> zsmalloc, not x86. So replace x86 dependeny with ZSMALLOC.
>
> Signed-off-by: Minchan Kim <minchan@...nel.org>

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>

> ---
>  drivers/staging/zcache/Kconfig |    3 +--
>  drivers/staging/zram/Kconfig   |    3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> index 7048e01..ceb7f28 100644
> --- a/drivers/staging/zcache/Kconfig
> +++ b/drivers/staging/zcache/Kconfig
> @@ -2,8 +2,7 @@ config ZCACHE
>        bool "Dynamic compression of swap pages and clean pagecache pages"
>        # X86 dependency is because zsmalloc uses non-portable pte/tlb
>        # functions
> -       depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
> -       select ZSMALLOC
> +       depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && ZSMALLOC
>        select CRYPTO_LZO
>        default n
>        help
> diff --git a/drivers/staging/zram/Kconfig b/drivers/staging/zram/Kconfig
> index 9d11a4c..e3ac62d 100644
> --- a/drivers/staging/zram/Kconfig
> +++ b/drivers/staging/zram/Kconfig
> @@ -2,8 +2,7 @@ config ZRAM
>        tristate "Compressed RAM block device support"
>        # X86 dependency is because zsmalloc uses non-portable pte/tlb
>        # functions
> -       depends on BLOCK && SYSFS && X86
> -       select ZSMALLOC
> +       depends on BLOCK && SYSFS && ZSMALLOC
>        select LZO_COMPRESS
>        select LZO_DECOMPRESS
>        default n
> --
> 1.7.9.5
>
>
>
> --
> Kind regards,
> Minchan Kim
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/