linux-kernel - Re: [PATCH] staging: comedi: Convert struct addi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FB49E74.8030409@mev.co.uk>
Date:	Thu, 17 May 2012 07:45:08 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
CC:	Greg KH <gregkh@...uxfoundation.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>,
	Ian Abbott <ian.abbott@....co.uk>
Subject: Re: [PATCH] staging: comedi: Convert struct addi_board initialization
 to C99 format

On 17/05/12 07:15, H Hartley Sweeten wrote:
> Wednesday, May 16, 2012 7:18 PM, Greg KH wrote:
>> On Wed, May 16, 2012 at 05:51:56PM -0700, H Hartley Sweeten wrote:
>>> Convert the struct addi_board initialization to C99 format and remove
>>> all the NULL or 0 initializers. This makes maintaining and editing the
>>> code simpler and less error prone.
>> Nice job, this driver is a pain to read...
>
> Thanks. I agree... I've been avoiding the addi drivers until now.
> Anytime a C file has an #include "something.c" it makes me
> shudder...
>
> I've been thinking that the addi stuff should really be broken up
> into some library modules with exported symbols for the individual
> addi drivers to use. I need to look a bit closer at them to see if
> this would work. Right now the whole thing is a bit of a mess.

TBH, I don't know how they got accepted into Comedi in the first place. 
  They tend to do their own thing as far as comedi instruction handling 
goes.  I've no idea who's using them.  It makes me shudder, too!  Did I 
mention the use of floating point in some of their drivers that we had 
to disable?

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/