linux-kernel - Re: [PATCH] gpio-mcp23s08: dbg_show: fix pullup configuration display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120518000133.C2EA43E062C@localhost>
Date:	Thu, 17 May 2012 18:01:33 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Peter Korsgaard <jacmet@...site.dk>, linux-kernel@...r.kernel.org
Cc:	Peter Korsgaard <jacmet@...site.dk>
Subject: Re: [PATCH] gpio-mcp23s08: dbg_show: fix pullup configuration display

On Wed, 25 Apr 2012 11:51:53 +0200, Peter Korsgaard <jacmet@...site.dk> wrote:
> Pullups are enabled when bits are set, not when cleared.
> 
> Signed-off-by: Peter Korsgaard <jacmet@...site.dk>

Applied, thanks.

g.

> ---
>  drivers/gpio/gpio-mcp23s08.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/gpio/gpio-mcp23s08.c
> index c5d83a8..0f42518 100644
> --- a/drivers/gpio/gpio-mcp23s08.c
> +++ b/drivers/gpio/gpio-mcp23s08.c
> @@ -353,7 +353,7 @@ static void mcp23s08_dbg_show(struct seq_file *s, struct gpio_chip *chip)
>  			chip->base + t, bank, t, label,
>  			(mcp->cache[MCP_IODIR] & mask) ? "in " : "out",
>  			(mcp->cache[MCP_GPIO] & mask) ? "hi" : "lo",
> -			(mcp->cache[MCP_GPPU] & mask) ? "  " : "up");
> +			(mcp->cache[MCP_GPPU] & mask) ? "up" : "  ");
>  		/* NOTE:  ignoring the irq-related registers */
>  		seq_printf(s, "\n");
>  	}
> -- 
> 1.7.10
> 

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/