[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20120517.200509.2290282427866555176.davem@davemloft.net>
Date: Thu, 17 May 2012 20:05:09 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: bpoirier@...e.de
Cc: netdev@...r.kernel.org, kuznet@....inr.ac.ru, jmorris@...ei.org,
yoshfuji@...ux-ipv6.org, kaber@...sh.net,
linux-kernel@...r.kernel.org, steffen.klassert@...unet.com
Subject: Re: [PATCH v3] xfrm: take iphdr size into account for esp payload
size calculation
From: Benjamin Poirier <bpoirier@...e.de>
Date: Wed, 16 May 2012 15:35:25 -0400
> Corrects the function that determines the esp payload size.
> The calculations done in esp4_get_mtu lead to overlength frames in transport
> mode for certain mtu values and suboptimal frames for others.
>
> According to what is done, mainly in esp_output(), net_header_len aka
> sizeof(struct iphdr) must be taken into account before doing the alignment
> calculation.
>
> Signed-off-by: Benjamin Poirier <bpoirier@...e.de>
This looks great.
Could you please fix net/ipv6/esp6.c too, it seems to have the same
exact bug.
Once you respin this patch with both ipv4 and ipv6 fixed, I'll apply
it.
Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists