linux-kernel - Re: [PATCH 2/5] regulator: tps65910: set of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120519174829.GZ4039@opensource.wolfsonmicro.com>
Date:	Sat, 19 May 2012 18:48:29 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	lrg@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] regulator: tps65910: set of_node for regulator
 register config

On Sat, May 19, 2012 at 08:04:07PM +0530, Laxman Dewangan wrote:

> set of_node parameter for regulator registration configuration
> parameter. This node contains the regulator related device node
> information for regulator which need to be register.

This isn't adding setting of the of_node...

> -#ifdef CONFIG_OF
> -		config.of_node = of_find_node_by_name(tps65910->dev->of_node,
> +		if (reg_node)
> +			config.of_node = of_find_node_by_name(reg_node,
>  							info->name);
> -#endif

...it's changing the value that's being configured.  The changelog
doesn't explain why this is being done.

Also, why is the ifdef being removed - won't that break the build?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)