linux-kernel - Re: [PATCH]ipc:fixed spacing issues in coding style.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120520154458.GG2895@linux.vnet.ibm.com>
Date:	Sun, 20 May 2012 08:44:58 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Jeffrin Jose <ahiliation@...oo.co.in>
Cc:	akpm@...ux-foundation.org, manfred@...orfullife.com,
	a.p.zijlstra@...llo.nl, josh@...htriplett.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]ipc:fixed spacing issues in coding style.

On Sun, May 20, 2012 at 04:31:13PM +0530, Jeffrin Jose wrote:
> Fixed spacing issues related to different operators
> like * and : found by checkpatch.pl tool in ipc/sem.c
> 
> Signed-off-by: Jeffrin Jose <ahiliation@...oo.co.in>

Looks good to me!

Reviewed-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

> ---
>  ipc/sem.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ipc/sem.c b/ipc/sem.c
> index 10386b8..9301595 100644
> --- a/ipc/sem.c
> +++ b/ipc/sem.c
> @@ -964,7 +964,7 @@ static int semctl_nolock(struct ipc_namespace *ns, int semid,
>  		up_read(&sem_ids(ns).rw_mutex);
>  		if (copy_to_user (arg.__buf, &seminfo, sizeof(struct seminfo))) 
>  			return -EFAULT;
> -		return (max_id < 0) ? 0: max_id;
> +		return (max_id < 0) ? 0 : max_id;
>  	}
>  	case IPC_STAT:
>  	case SEM_STAT:
> @@ -1372,7 +1372,7 @@ static struct sem_undo *find_alloc_undo(struct ipc_namespace *ns, int semid)
>  	spin_lock(&ulp->lock);
>  	un = lookup_undo(ulp, semid);
>  	spin_unlock(&ulp->lock);
> -	if (likely(un!=NULL))
> +	if (likely(un != NULL))
>  		goto out;
>  	rcu_read_unlock();
> 
> @@ -1732,7 +1732,7 @@ void exit_sem(struct task_struct *tsk)
> 
>  		/* perform adjustments registered in un */
>  		for (i = 0; i < sma->sem_nsems; i++) {
> -			struct sem * semaphore = &sma->sem_base[i];
> +			struct sem *semaphore = &sma->sem_base[i];
>  			if (un->semadj[i]) {
>  				semaphore->semval += un->semadj[i];
>  				/*
> -- 
> 1.7.10
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/