linux-kernel - Re: [PATCH]ipc:fixed spacing issues in coding style.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120520190430.GB6475@leaf>
Date:	Sun, 20 May 2012 12:04:30 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	Jeffrin Jose <ahiliation@...oo.co.in>
Cc:	akpm@...ux-foundation.org, manfred@...orfullife.com,
	a.p.zijlstra@...llo.nl, paulmck@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]ipc:fixed spacing issues in coding style.

On Sun, May 20, 2012 at 04:31:13PM +0530, Jeffrin Jose wrote:
> Fixed spacing issues related to different operators
> like * and : found by checkpatch.pl tool in ipc/sem.c
> 
> Signed-off-by: Jeffrin Jose <ahiliation@...oo.co.in>

All three of the spacing fixes in this patch look correct.
Reviewed-by: Josh Triplett <josh@...htriplett.org>

However, I see one instance of another type of spacing issue in the
patch context:

> --- a/ipc/sem.c
> +++ b/ipc/sem.c
> @@ -964,7 +964,7 @@ static int semctl_nolock(struct ipc_namespace *ns, int semid,
>  		up_read(&sem_ids(ns).rw_mutex);
>  		if (copy_to_user (arg.__buf, &seminfo, sizeof(struct seminfo))) 

copy_to_user should not have a space before its open parenthesis.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/